Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ECSCredentialsProvider Part 2 #235

Merged
merged 9 commits into from
May 3, 2024

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented May 1, 2024

Issue:
awslabs/mountpoint-s3#859

Description of changes:

  • Supports EcsContainer as a source for STSCredentials Provider.
  • Refactors the STS tests with the following:
    • Update mocked connection manager to properly trigger shutdown callbacks.
    • Update mocked connection manager to support multiple request responses.
    • Update all tests to wait for all connection managers to properly shutdown.
  • Reduce the NumRetries from 8 to 3 for STS and CognitoCredentialsProvider.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.99%. Comparing base (40f0e92) to head (59090a3).

Files Patch % Lines
source/credentials_provider_profile.c 90.90% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           fix-sts-profile-provider     #235      +/-   ##
============================================================
+ Coverage                     79.95%   79.99%   +0.03%     
============================================================
  Files                            33       33              
  Lines                          5898     5914      +16     
============================================================
+ Hits                           4716     4731      +15     
- Misses                         1182     1183       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waahm7 waahm7 changed the title WIP | Refactor ECSCredentialsProvider Refactor ECSCredentialsProvider Part 1 May 1, 2024
@waahm7 waahm7 marked this pull request as ready for review May 1, 2024 22:43
@waahm7 waahm7 closed this May 2, 2024
@waahm7 waahm7 changed the title Refactor ECSCredentialsProvider Part 1 WIP | Refactor ECSCredentialsProvider Part 2 May 2, 2024
@waahm7 waahm7 reopened this May 2, 2024
@waahm7 waahm7 changed the base branch from main to fix-sts-profile-provider May 2, 2024 16:34
@waahm7 waahm7 marked this pull request as draft May 2, 2024 22:22
@waahm7 waahm7 changed the title WIP | Refactor ECSCredentialsProvider Part 2 Refactor ECSCredentialsProvider Part 2 May 3, 2024
@waahm7 waahm7 marked this pull request as ready for review May 3, 2024 19:15
@waahm7 waahm7 merged commit 5d79768 into fix-sts-profile-provider May 3, 2024
29 checks passed
@waahm7 waahm7 deleted the fix-sts-ecs-provider branch May 3, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants