Shutdown callback support for all credentials providers #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretambrose
changed the title
graebm
reviewed
Sep 17, 2019
…into ImdsBootstrapRelease
bretambrose
changed the title
justinboswell
approved these changes
Nov 19, 2019
graebm
approved these changes
Nov 20, 2019
include/aws/auth/credentials.h
Outdated
| struct aws_byte_cursor access_key_id, | ||
| struct aws_byte_cursor secret_access_key, | ||
| struct aws_byte_cursor session_token); | ||
| struct aws_credentials_provider_static_options *options); |
| */ | ||
| AWS_AUTH_API | ||
| struct aws_signer *aws_signer_new_aws(struct aws_allocator *allocator); | ||
| int aws_sign_request_aws( |
There was a problem hiding this comment.
Worth having a typedef to cover all signers?
typedef int aws_signing_fn(.....);
ColdenCullen
approved these changes
Nov 20, 2019
| int aws_sign_request_aws( | ||
| struct aws_allocator *allocator, | ||
| const struct aws_signable *signable, | ||
| const struct aws_signing_config_base *base_config, |
There was a problem hiding this comment.
This can be aws_signing_config_aws now!
source/credentials_utils.c
Outdated
Comment on lines
52
to
53
| if (provider) { | ||
| if (provider->shutdown_options.shutdown_callback) { |
There was a problem hiding this comment.
[nit]
if (provider && provider->shutdown_options.shutdown_callback) {
rccarper
pushed a commit
that referenced
this pull request
Feb 7, 2020
* log errors in decoder * slight modifications to decoder, while we're in here thinking about what might go wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.