Skip to content

Commit

Permalink
Disable aws-lc's codegen. (#90)
Browse files Browse the repository at this point in the history
Background: aws-lc uses codegen to create some of its source files, and it runs these generators if the user's machine has Go and Perl installed. However, up-to-date versions of the generated files are already committed to the repo, so it's not necessary for users to run codegen on their machines.

This codegen has led to unexpected issues (ex: failure due to network access at build time) so let's just turn it off and reduce unnecessary complexity.
  • Loading branch information
graebm committed May 5, 2021
1 parent 936ec2c commit e44068d
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions cmake/modules/aws-lc.cmake
Expand Up @@ -14,6 +14,8 @@ execute_process(
-DCMAKE_POSITION_INDEPENDENT_CODE=ON
-DBUILD_TESTING=OFF
-DBUILD_LIBSSL=OFF
-DDISABLE_GO=ON # disables codegen
-DDISABLE_PERL=ON # disables codegen
-DBUILD_SHARED_LIBS=${BUILD_SHARED_LIBS}
${CMAKE_CURRENT_SOURCE_DIR}/crt/aws-lc
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/aws-lc
Expand Down

0 comments on commit e44068d

Please sign in to comment.