Fix build against openssl 1.0.2 #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingDaoK
approved these changes
Oct 12, 2023
waahm7
approved these changes
Oct 12, 2023
| @@ -11,7 +11,10 @@ | |||
| #include <openssl/evp.h> | |||
|
|
|||
| #if !defined(OPENSSL_IS_AWSLC) && !defined(OPENSSL_IS_BORINGSSL) | |||
There was a problem hiding this comment.
nit: Sorry existing code but I think we should probably use defined(OPENSSL_IS_OPENSSL) instead. This check may break in the future if we add more variants.
There was a problem hiding this comment.
openssl does not define OPENSSL_IS_OPENSSL. we do define it manually in another place to the exact same thing as above. its something to consider and will need a bit of refactoring. We probably would want to pull that define into private common header that can be included in all openssl code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
in 1.0.2 evperr header did not existing and errors were instead defined in evp.h
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.