Enable runtime use in a musl-based static binary (where dlopen will return null) #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that references are forced when linking statically, the assertion is no longer necessary. See awslabs#54
elerch
force-pushed
the
static-musl-builds
branch
from
0a11a3c
to
ee46efc
Compare
|
|
tobim
reviewed
Mar 8, 2024
| @@ -122,6 +122,7 @@ bool s_resolve_hmac_102(void *module) { | |||
| if (has_102_symbols) { | |||
| FLOGF("found static libcrypto 1.0.2 HMAC symbols"); | |||
| } else { | |||
| AWS_FATAL_ASSERT(!module && "Cannot read process symbols and libcrypto 1.0.2 HMAC symbols not found"); | |||
There was a problem hiding this comment.
These asserts break the dynamically linked library.
|
We've recently added musl support. Please let us know if you run into any issues when using it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is somewhat of a continuation of Issue #54.
These changes remove the assertion that the process module can be read by the dynamic linker. They also add assertions that if the module was not read by the dynamic linker, then symbols for HMAC/MD modules already exist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.