Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

claim range for aws-crt-kotlin #1095

Merged
merged 2 commits into from
Mar 8, 2024
Merged

claim range for aws-crt-kotlin #1095

merged 2 commits into from
Mar 8, 2024

Conversation

aajtodd
Copy link
Contributor

@aajtodd aajtodd commented Mar 8, 2024

Issue #, if available:
n/a

Description of changes:

  • Claims package ID 16 for aws-crt-kotlin (native) bindings.
  • Increase max package slots to 32

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Claims package ID 16 for `aws-crt-kotlin` (native) bindings.
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.04%. Comparing base (fcadc0d) to head (a0b7ce5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1095   +/-   ##
=======================================
  Coverage   83.04%   83.04%           
=======================================
  Files          56       56           
  Lines        5762     5762           
=======================================
  Hits         4785     4785           
  Misses        977      977           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aajtodd
Copy link
Contributor Author

aajtodd commented Mar 8, 2024

Looks like package slots is capped at 16

Using package ID of 16 results in:

Bad log subject slot index 0x0000000000000010

What do you want this updated to? 17? 24? 32?

@graebm
Copy link
Contributor

graebm commented Mar 8, 2024

32 seems fine. Good old powers of two

@graebm graebm merged commit 4e1cfca into main Mar 8, 2024
52 checks passed
@graebm graebm deleted the aajtodd-update-readme branch March 8, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants