Best Effort Thread Pinning to CPU_ID #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 90c57d0.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1096 +/- ##
==========================================
+ Coverage 83.04% 83.15% +0.11%
==========================================
Files 56 56
Lines 5762 5765 +3
==========================================
+ Hits 4785 4794 +9
+ Misses 977 971 -6 ☔ View full report in Codecov by Sentry. |
TingDaoK
reviewed
Mar 11, 2024
TingDaoK
approved these changes
Mar 11, 2024
TingDaoK
reviewed
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Sometimes,
pthread_createcan fail with anEINVALerror, or on FreeBSD, it can fail with anEDEADLKerror if thecpu_idis restricted. Since pinning to a particularcpu_idis supposed to be best-effort, try to launch a thread again without pinning to a specificcpu_id.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.