clang-format 18

[graebm]

Issue:

• We've used clang-format 9 since forever, but it's not easy for people to get such an old version anymore.
• You really need everyone on the same exact version clang-format, even PATCH matters
• It's very hard to get the same version on everyone's machine (Ubuntu 24 has 18, brew on MacOS has 18, but Amazon Linux 2 only has 11, and AL2023 only has 15)

Description of Changes:

• start using latest version of clang-format: 18.1.6
• use pipx to install and run clang-format from PyPI. This lets everyone run the same version, regardless of OS
• rewrite format-check.sh as format-check.py
  • now we can run it on Windows
  • most people on this team know Python better than Bash
  • add -i option to edit files in place
  • the script runs the specific clang-format version via pipx, so even if you have some other version of clang-format installed, the script will get it right
• CI just runs ./format-check.py instead of using some 3rdparty Github Action

Updating your Machine:

• MacOS:
  • if you have clang-format 9 from homebrew, uninstall it: brew uninstall llvm@9
  • if you have another version from homebrew, uninstall it: brew uninstall clang-format
  • install pipx: brew install pipx
  • ensure programs that pipx install are on your $PATH: pipx ensurepath
  • install the correct clang-format, so your IDE can use it too: pipx install clang-format==18.1.6

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.07%. Comparing base (4f874ce) to head (f463324).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1113   +/-   ##
=======================================
  Coverage   83.07%   83.07%           
=======================================
  Files          56       56           
  Lines        5756     5756           
=======================================
  Hits         4782     4782           
  Misses        974      974           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[waahm7]

🥳 🎆🎆 🎊🎊🎊🥳

[waahm7]

trivial:

Suggested change

	# 18.1.6 is the latest version as of June 2024