Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aws_host_utils_is_ipv6 function #1114

Merged
merged 3 commits into from
May 10, 2024
Merged

Fix aws_host_utils_is_ipv6 function #1114

merged 3 commits into from
May 10, 2024

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented May 10, 2024

Description of changes:

  • The host will always be stripped of [] and will never be enclosed in it.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.12%. Comparing base (24e2396) to head (8a280d6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1114      +/-   ##
==========================================
- Coverage   83.14%   83.12%   -0.03%     
==========================================
  Files          56       56              
  Lines        5760     5753       -7     
==========================================
- Hits         4789     4782       -7     
  Misses        971      971              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waahm7 waahm7 merged commit 36a716e into main May 10, 2024
52 checks passed
@waahm7 waahm7 deleted the fix-is-ipv6-function branch May 10, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants