Do not use addr2line by default, backtrace_symbols will do the job #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rccarper
reviewed
Dec 3, 2020
| @@ -132,11 +142,20 @@ static int s_test_memtrace_stacks(struct aws_allocator *allocator, void *ctx) { | |||
| /* if this is not a debug build, there may not be symbols, so the test cannot | |||
| * verify if a best effort was made */ | |||
| #if defined(DEBUG_BUILD) | |||
There was a problem hiding this comment.
Do we still need the define? (It looks like the new approach is meant to handle symbols for a debug build and having no symbols for a non-debug build?)
There was a problem hiding this comment.
Yeah, I can't prevent the optimizer from removing those functions, even with noinline.
rccarper
approved these changes
Dec 3, 2020
Yamakuzure
added a commit
to Yamakuzure/gentoo
that referenced
this pull request
Dec 12, 2020
This commit updates to version 0.4.62 with the following enhancements * Print CMake version when configuring. [0] * Re-adding SOVERSION to CMakeLists.txt [1] * Disabled MSVC 2015's non-constant aggregate initializer warning [2] * Do not use addr2line by default, backtrace_symbols will do the job [3] * Fixed memtrace/stack decoding test so it works more robustly * Removes an unnecessary API hopefully before anyone uses it externally Also block dev-util/cmake-3.19.0 and dev-util/cmake-3.19.1, which introduced a regression causing configure phase to fail. [4] [0] awslabs/aws-c-common#701 [1] awslabs/aws-c-common#702 [2] awslabs/aws-c-common#738 [3] awslabs/aws-c-common#739 [4] https://gitlab.kitware.com/cmake/cmake/-/issues/21529 Closes: https://bugs.gentoo.org/755932 Package-Manager: Portage-3.0.11, Repoman-3.0.2 Signed-off-by: Sven Eden <sven.eden@prydeworx.com>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Dec 13, 2020
This commit updates to version 0.4.62 with the following enhancements * Print CMake version when configuring. [0] * Re-adding SOVERSION to CMakeLists.txt [1] * Disabled MSVC 2015's non-constant aggregate initializer warning [2] * Do not use addr2line by default, backtrace_symbols will do the job [3] * Fixed memtrace/stack decoding test so it works more robustly * Removes an unnecessary API hopefully before anyone uses it externally Also block dev-util/cmake-3.19.0 and dev-util/cmake-3.19.1, which introduced a regression causing configure phase to fail. [4] [0] awslabs/aws-c-common#701 [1] awslabs/aws-c-common#702 [2] awslabs/aws-c-common#738 [3] awslabs/aws-c-common#739 [4] https://gitlab.kitware.com/cmake/cmake/-/issues/21529 Closes: https://bugs.gentoo.org/755932 Package-Manager: Portage-3.0.11, Repoman-3.0.2 Signed-off-by: Sven Eden <sven.eden@prydeworx.com> Signed-off-by: Joonas Niilola <juippis@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.