fixed endpoint not being read in arguments #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwistedTwigleg
approved these changes
May 2, 2022
bin/elastipubsub/main.c
Outdated
| @@ -158,24 +159,26 @@ static void s_parse_options(int argc, char **argv, struct app_ctx *ctx) { | |||
| case 'h': | |||
| s_usage(0); | |||
| break; | |||
| case 0x02: { | |||
There was a problem hiding this comment.
Super minor question: Should we add a comment saying something like "start of text" or "stx" here? I found it a little confusing initially since the other switch statements are comparing against characters, but then once I searched up what 0x02 is mapped to it made sense, but I'm wondering if perhaps it would be best to add a quick comment just so at a glance it is more obvious what it is looking for.
There was a problem hiding this comment.
Explicitly added the endpoint argument and instructions
TwistedTwigleg
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small bug fix in elastipubsub
Description of changes:
endpoint argument was not being parsed correctly and is now being read and stored
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.