Add on_closed callback to MQTT311 #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbSteveK
reviewed
Feb 3, 2023
sbSteveK
approved these changes
Feb 3, 2023
|
Thanks! Merging into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds a
on_closedcallback that is called whenever a MQTT311 connection is fully closed. This is similar to theon_disconnectcallback, but unlike that callback, this callback can be set once and will be called for every single successful, user-initiated disconnect, unlike theon_disconnectcallback that is set each time you calldisconnect.This is for exposing this callback to the CRTs, which will allow the on_closed callback to be bubbled up akin to the V1 SDK API (reference).
Also adds tests to ensure the functionality works as expected and only is invoked on successful disconnects and not interrupts.
Note: If #254 is merged first, then this PR will need modification to call the
on_closedcallback when the disconnect is invoked via the reconnect, and vice versa should this PR be merged first.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.