Mqtt3-to-5 Adapter Config APIs #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 19, 2023 15:23
…cs to the adapter's release and shutdown process
…gs in a subsequent PR
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## RefactorAdapterRefcount #286 +/- ##
===========================================================
- Coverage 81.20% 79.74% -1.47%
===========================================================
Files 18 18
Lines 7322 7621 +299
===========================================================
+ Hits 5946 6077 +131
- Misses 1376 1544 +168
☔ View full report in Codecov by Sentry. |
bretambrose
changed the title
TwistedTwigleg
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests added for what can actually be checked in the unit test framework. Proxy and websocket correctness will need integration tests run in codebuild which we don't have set up yet for aws-c-mqtt.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.