Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cmake config #294

Merged
merged 2 commits into from
May 24, 2023
Merged

fix cmake config #294

merged 2 commits into from
May 24, 2023

Conversation

TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented May 24, 2023

  • MQTT_WITH_WEBSOCKETS has been removed, but the cmake config was not updated with it
  • Also, remove the dependency on aws-c-io, as it's covered by aws-c-http already.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2023

Codecov Report

Patch coverage: 37.65% and project coverage change: -0.93 ⚠️

Comparison is base (a661c9d) 81.20% compared to head (1a1e05d) 80.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
- Coverage   81.20%   80.28%   -0.93%     
==========================================
  Files          18       18              
  Lines        7322     7572     +250     
==========================================
+ Hits         5946     6079     +133     
- Misses       1376     1493     +117     
Impacted Files Coverage Δ
source/client_impl_shared.c 80.95% <ø> (+3.67%) ⬆️
source/mqtt.c 94.59% <ø> (ø)
source/mqtt3_to_mqtt5_adapter.c 42.50% <35.64%> (-33.70%) ⬇️
source/client.c 69.17% <80.00%> (+3.57%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TingDaoK TingDaoK merged commit a760f42 into main May 24, 2023
31 checks passed
@TingDaoK TingDaoK deleted the fix-cmake-config branch May 24, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants