Adapter log subject and large-scale name change #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t correct to use
Shared subscription set implementation * Topic tree support for mqtt 311 per-subscription publish received callbacks * Per-topic-filter subscription record tracking for resubscribe support * The subscription set could eventually replace the topic tree in the mqtt 311 implementation, but for now leave it alone --------- Co-authored-by: Bret Ambrose <bambrose@amazon.com>
sbSteveK
reviewed
Jul 26, 2023
| @@ -91,6 +91,7 @@ enum aws_mqtt_log_subject { | |||
| AWS_LS_MQTT5_GENERAL, | |||
| AWS_LS_MQTT5_CLIENT, | |||
| AWS_LS_MQTT5_CANARY, | |||
| AWS_LS_MQTT5_TO_MQTT3_ADAPTER, | |||
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## AdapterFinalPolish #312 +/- ##
===================================================
Coverage 81.70% 81.70%
===================================================
Files 19 19
Lines 8578 8578
===================================================
Hits 7009 7009
Misses 1569 1569
☔ View full report in Codecov by Sentry. |
sbSteveK
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.