Fix websocket transfer callback userdata & server name in tls_options #313
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #313 +/- ##
==========================================
- Coverage 82.17% 82.08% -0.09%
==========================================
Files 20 20
Lines 8661 8670 +9
==========================================
Hits 7117 7117
- Misses 1544 1553 +9
☔ View full report in Codecov by Sentry. |
xiazhvera
changed the title
source/v5/mqtt5_to_mqtt3_adapter.c
Outdated
| @@ -326,6 +340,13 @@ static struct aws_mqtt_adapter_connect_task *s_aws_mqtt_adapter_connect_task_new | |||
| connect_task->clean_session = connection_options->clean_session; | |||
|
|
|||
| return connect_task; | |||
|
|
|||
| error: | |||
| aws_ref_count_release(&adapter->internal_refs); | |||
There was a problem hiding this comment.
Instead of doing this, let's move the acquire after the last control flow that can error out. Having to release refs in error blocks is something to avoid if possible.
There was a problem hiding this comment.
The task is using the adapter->allocator. If we do not acquire the adapter beforehand, would there be chance that that the allocator get released with the adapter?
source/v5/mqtt5_to_mqtt3_adapter.c
Outdated
| @@ -314,6 +314,20 @@ static struct aws_mqtt_adapter_connect_task *s_aws_mqtt_adapter_connect_task_new | |||
| if (connection_options->tls_options) { | |||
| aws_tls_connection_options_copy(&connect_task->tls_options, connection_options->tls_options); | |||
There was a problem hiding this comment.
This call can fail. Since s_aws_mqtt_adapter_connect_task_new is already changed, maybe add a check for this call as well?
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.