Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mqtt311 compliance client behavior2 #326

Merged
merged 10 commits into from Aug 29, 2023
Merged

Conversation

bretambrose
Copy link
Contributor

  • Update 311 client to set dup flag when resubmitting qos 1 publishes on session resumption
  • Additional tests are client behavior related to dup flag and resubmitting subscribe/unsubscribe which the 311 spec forgot to forbid

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bretambrose bretambrose changed the base branch from Mqtt311ComplianceDecode to main August 29, 2023 16:13
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 98.11% and project coverage change: +0.18% 🎉

Comparison is base (6ee615f) 82.23% compared to head (a44784f) 82.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
+ Coverage   82.23%   82.42%   +0.18%     
==========================================
  Files          20       20              
  Lines        8709     8729      +20     
==========================================
+ Hits         7162     7195      +33     
+ Misses       1547     1534      -13     
Files Changed Coverage Δ
source/v5/mqtt5_utils.c 81.28% <ø> (+1.19%) ⬆️
source/client.c 70.81% <96.15%> (+1.11%) ⬆️
source/mqtt.c 96.00% <100.00%> (+1.40%) ⬆️
source/packets.c 85.19% <100.00%> (+0.33%) ⬆️
source/v5/mqtt5_options_storage.c 90.59% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bretambrose bretambrose merged commit ee06ce3 into main Aug 29, 2023
31 checks passed
@bretambrose bretambrose deleted the Mqtt311ComplianceClientBehavior2 branch August 29, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants