Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove callback severance on 5-to-3 adapter #329

Merged
merged 3 commits into from Oct 19, 2023
Merged

Conversation

bretambrose
Copy link
Contributor

@bretambrose bretambrose commented Oct 6, 2023

  1. Strip out everything related to the callback firewall on shutdown
  2. Add a vtable to adapter operations and a fail function for publish, subscribe, unsubscribe
  3. Invoke fail on all incomplete operations during final adapter shutdown
  4. Add a test that verifies completion callback invocation after the adapter is shut down

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (0cc50d1) 82.34% compared to head (4f5f9a9) 82.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
+ Coverage   82.34%   82.38%   +0.04%     
==========================================
  Files          20       20              
  Lines        8738     8721      -17     
==========================================
- Hits         7195     7185      -10     
+ Misses       1543     1536       -7     
Files Coverage Δ
source/v5/mqtt5_to_mqtt3_adapter.c 76.33% <92.68%> (+0.18%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiazhvera xiazhvera merged commit c475ef1 into main Oct 19, 2023
31 checks passed
@xiazhvera xiazhvera deleted the RemoveCallbackSeverance branch October 19, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants