Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return an error code when an mqtt5 puback has a failing reason code #352

Merged
merged 4 commits into from Feb 29, 2024

Conversation

sbSteveK
Copy link
Contributor

  • mqtt3 should have a non-successful error_code when a failed reason code puback is received using the mqtt5 to mqtt3 adapter.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.57%. Comparing base (d4346e0) to head (a417561).

Files Patch % Lines
source/v5/mqtt5_to_mqtt3_adapter.c 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
+ Coverage   82.55%   82.57%   +0.01%     
==========================================
  Files          20       20              
  Lines        8764     8767       +3     
==========================================
+ Hits         7235     7239       +4     
+ Misses       1529     1528       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bretambrose bretambrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test and ship it

source/v5/mqtt5_to_mqtt3_adapter.c Outdated Show resolved Hide resolved
@sbSteveK sbSteveK merged commit 74da9ca into main Feb 29, 2024
31 checks passed
@sbSteveK sbSteveK deleted the mqtt5-to-mqtt3-puback-error branch February 29, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants