Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MQTT5 ping timeout #361

Merged
merged 2 commits into from Mar 25, 2024
Merged

Refactor MQTT5 ping timeout #361

merged 2 commits into from Mar 25, 2024

Conversation

bretambrose
Copy link
Contributor

  • Relaxes validation on ping timeout configuration value.
  • Ping timeout now a function of base configuration value and the connection's negotiated keep alive.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.61%. Comparing base (74da9ca) to head (20ab43b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
+ Coverage   82.60%   82.61%   +0.01%     
==========================================
  Files          20       20              
  Lines        8767     8756      -11     
==========================================
- Hits         7242     7234       -8     
+ Misses       1525     1522       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

connection_ping_timeout = half_keep_alive_nanos;
}

AWS_LOGF_DEBUG(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial: Should this log only occur when the set ping timout is dynamically altered? i.e. in the if block that checks whether we should apply the half_keep_alive_nanos ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine the way it is as a direct reminder so that you don't have to have access to the log of the original settings to know.

Trivial: Should this log only occur when the set ping timout is dynamically altered? i.e. in the if block that checks whether we should apply the half_keep_alive_nanos ?

@bretambrose bretambrose merged commit 1efb8f9 into main Mar 25, 2024
31 checks passed
@bretambrose bretambrose deleted the KeepAliveRefactor branch March 25, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants