s3_endpoint: log ID of new connection_manager instead of nil #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the way the function is called, `endpoint->http_connection_manager` is `NULL`, since nothing has been assigned yet. Hence the statement always prints `nil`, as in ``` [DEBUG] 2022-08-19 12:19:06.073 S3Endpoint [140627654626880] id=0x7fe63ff2b8e0: Created connection manager (nil) for endpoint ``` The absence of the ID makes it hard to trace problems in allocating/releasing the `http_connection_manager`. Print its address instead, consistent with other output.
TingDaoK
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the way the function is called,
endpoint->http_connection_manageris alwaysNULLhere, since nothing has been assigned yet.Hence the log statement consistently prints
nil, as inThe absence of the ID makes it hard to trace problems in allocating/releasing the
http_connection_manager.Print its address instead, consistent with other output.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.