Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instead of skipping, let's prepare the parts and mark it noop #356

Merged
merged 70 commits into from Oct 16, 2023

Conversation

TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Oct 5, 2023

  • Refactoring the resume logic to instead of skipping parts during preparing other parts, we prepare those parts already uploaded, and then make it noop. After we read the part, we check the checksum and length.

TODO:

Maybe, we can be more smarter? If the part uploaded doesn't have a checksum, we can skip reading the part? Or let user config that if they want us to read the parts uploaded.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@TingDaoK TingDaoK marked this pull request as ready for review October 6, 2023 18:53
source/s3_auto_ranged_put.c Outdated Show resolved Hide resolved
source/s3_auto_ranged_put.c Show resolved Hide resolved
source/s3_auto_ranged_put.c Show resolved Hide resolved
TingDaoK and others added 2 commits October 9, 2023 15:40
Co-authored-by: Michael Graeb <graebm@amazon.com>
include/aws/s3/private/s3_meta_request_impl.h Outdated Show resolved Hide resolved
source/s3_auto_ranged_put.c Outdated Show resolved Hide resolved
source/s3_auto_ranged_put.c Show resolved Hide resolved
source/s3_auto_ranged_put.c Outdated Show resolved Hide resolved
source/s3_auto_ranged_put.c Outdated Show resolved Hide resolved
source/s3_auto_ranged_put.c Outdated Show resolved Hide resolved
source/s3_auto_ranged_put.c Outdated Show resolved Hide resolved
source/s3_auto_ranged_put.c Outdated Show resolved Hide resolved
source/s3_auto_ranged_put.c Outdated Show resolved Hide resolved
source/s3_auto_ranged_put.c Show resolved Hide resolved
Base automatically changed from para-pre-rcbc to main October 16, 2023 21:16
@TingDaoK TingDaoK merged commit f710806 into main Oct 16, 2023
30 checks passed
@TingDaoK TingDaoK deleted the para-pre-keep-reading-checksum branch October 16, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants