Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the behavior for profile override #30

Merged
merged 2 commits into from
May 30, 2023
Merged

Conversation

TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented May 24, 2023

Issue #, if available:

  • We say we do what aws-cli does, here
  • But, according to CLI doc here:

Specifies the name of the AWS CLI profile with the credentials and options to use. This can be the name of a profile stored in a credentials or config file, or the value default to use the default profile.
If defined, this environment variable overrides the behavior of using the profile named [default] in the configuration file. You can override this environment variable by using the --profile command line parameter.

Description of changes:

  • Change the behavior to make sure the provided profile override the environment variable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4047b61) 67.86% compared to head (fefbab5) 67.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage   67.86%   67.86%           
=======================================
  Files           9        9           
  Lines        2605     2605           
=======================================
  Hits         1768     1768           
  Misses        837      837           
Impacted Files Coverage Δ
source/aws_profile.c 68.16% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@waahm7 waahm7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix & ship.

source/aws_profile.c Outdated Show resolved Hide resolved
source/aws_profile.c Outdated Show resolved Hide resolved
@TingDaoK TingDaoK merged commit df511a1 into main May 30, 2023
31 checks passed
@TingDaoK TingDaoK deleted the update-profile-override branch May 30, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants