Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/settable boto3 session #32

Merged
merged 2 commits into from
Aug 15, 2022
Merged

Feature/settable boto3 session #32

merged 2 commits into from
Aug 15, 2022

Conversation

chamcca
Copy link
Contributor

@chamcca chamcca commented Aug 10, 2022

Issue #, if available: #31

Description of changes:

  • enable setting and updating boto3 Session for all operations
  • refactor error module -> errors hiding private modules

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

dgraeber
dgraeber approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@dgraeber dgraeber left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@chamcca chamcca merged commit 3d37eba into awslabs:main Aug 15, 2022
@chamcca chamcca deleted the feature/settable-boto3-session branch August 15, 2022 19:29
@chamcca chamcca linked an issue Aug 22, 2022 that may be closed by this pull request
[FEATURE] Enable setting and updating of boto3 Session #31
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgraeber dgraeber dgraeber approved these changes

@rb201 rb201 rb201 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Enable setting and updating of boto3 Session
3 participants
@chamcca @dgraeber @rb201