fix: extra_files failed to create dest subdirectories #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgraeber
reviewed
Apr 27, 2023
| @@ -129,7 +129,10 @@ def generate_bundle( | |||
| if files is not None: | |||
| for src_file, name in files: | |||
| LOGGER.debug(f"***file={src_file}:name={name}") | |||
| shutil.copy(src=src_file, dst=os.path.realpath(os.path.join(bundle_dir, name))) | |||
| dst_file = os.path.realpath(os.path.join(bundle_dir, name)) | |||
| if "/" in name: | |||
There was a problem hiding this comment.
How will this work on windows OS?
There was a problem hiding this comment.
paths on windows for python still need to be specified with /.
dgraeber
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Fixes: #88
Description of changes:
filesandextra_filesfailed to create destination subdirectoriespre_execution_commandsandextra_pre_execution_commandsto enable commands in the Build phase prior toremote_functionexecutionBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.