Tune OpenBSD support #219
Merged
Tune OpenBSD support #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If builder is running, then python is already installed; no need to attempt to install it again or delay the build by installing just another version of python.
The GitHub action I was originally using did not come with sudo installed and relied on doas which comes in the base OpenBSD install. I've now switched to a more robust action which includes sudo, among other things. This commit reverts support for doas in crt-builder, returning the code to its much simpler pre-doas state.
graebm
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Tune OpenBSD support based on learnings from using crt-builder with downstream CRT projects.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.