FIPS #267
FIPS #267
Conversation
| import builder.core.util as util | ||
|
|
||
| URLs = { | ||
| 'linux-armv6': 'https://go.dev/dl/go1.21.5.linux-armv6l.tar.gz', |
There was a problem hiding this comment.
any specific reason for 1.25.5?
if we just want latest versions, looks like we can them up here https://go.dev/dl/?mode=json
| @@ -24,6 +24,12 @@ RUN apt-get update -qq \ | |||
| ca-certificates \ | |||
| && apt-get clean | |||
|
|
|||
| # Add the longsleep/golang-backports PPA | |||
| RUN apt-get update && apt-get install -y software-properties-common && add-apt-repository ppa:longsleep/golang-backports && apt-get update | |||
There was a problem hiding this comment.
debatable: I would rather investigate the failure on x64 instead of having two different methods for installing GO.
There was a problem hiding this comment.
I did spend half a day to investigate it, and I don't know.
The issue is when we extract the go.tar.gz something failed. I tried different packages, and different ways to extract, no luck.
It only happens for ubuntu, and I gave up
| @@ -18,7 +18,8 @@ RUN apk add \ | |||
| ca-certificates \ | |||
| cmake \ | |||
| bash \ | |||
| aws-cli | |||
| aws-cli \ | |||
| perl-strictures | |||
There was a problem hiding this comment.
Why do we need this weird specific package?
https://metacpan.org/pod/strictures
strictures - Turn on strict and make most warnings fatal
Is there something more basic, named like perl?
There was a problem hiding this comment.
yeah, but aws-lc needs strict module for perl.
anyway, we are not turning fips on by default now. I can remove this
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.