Disable windows certificate store setup #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretambrose
reviewed
Feb 2, 2024
sfod
approved these changes
Feb 2, 2024
|
It is a temp workaround to unblock the CI in case anyone would need an emergency release. It would be best if we could provide a true fix. |
sfod
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Temporary disable the windows certificate store setup to unblock downstream CI.
The downstream CI test for windows could be verified at: awslabs/aws-crt-nodejs#531
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.