Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please clarify version stability #93

Closed
remicollet opened this issue Mar 14, 2023 · 8 comments
Closed

Please clarify version stability #93

remicollet opened this issue Mar 14, 2023 · 8 comments
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@remicollet
Copy link
Contributor

According to https://pecl.php.net/package/awscrt

  • 1.0.6, 1.07, 1.0.8 are "stable"
  • 1.0.9 and 1.0.10 are "devel" which seems strange

Usually, when a stable version is released, next are also stable
and testing versions are released using "beta" or "RC" suffix

Can you please clarify ?

@remicollet remicollet added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 14, 2023
@remicollet
Copy link
Contributor Author

Also, on github, only version up to 1.0.4 have tag:
https://github.com/awslabs/aws-crt-php/tags

@TingDaoK
Copy link
Contributor

Non of those are really stable, we still have issue to build from PECL, we will fix the version issue after we fix the build.

@TingDaoK
Copy link
Contributor

TingDaoK commented Mar 14, 2023

We are working on fixing the issue we currently have from pecl install awscrt and I don't really know what the best way to test.

Here is what I plan to do:

  • We will have all those 1.0.* as "devel" to test and make sure we fixed everything from pecl install.
  • We will publish 1.1.* as "stable" afterward and make sure that the PECL package version line up with the github release.

If you know what's the proper way to test pecl install locally, or more gracefully instead of publishing to PECL, please let us know. I haven't really found anything from PECL guidance.

BTW: If you, by any chance, can help us to apply for a PECL account as a PHP maintainer, it will be greatly helpful.

@remicollet
Copy link
Contributor Author

If you know what's the proper way to test pecl install locally, or more gracefully instead of publishing to PECL, please let us know. I haven't really found anything from PECL guidance.

pecl install /path/to/foo-1.2.3.tgz

BTW: If you, by any chance, can help us to apply for a PECL account as a PHP maintainer, it will be greatly helpful.

Ask on pecl devel mailing list

@remicollet
Copy link
Contributor Author

remicollet commented Mar 15, 2023

It looks like you are bitten by out of sources build

You have to use full paths defined as $abs_builddir and $ext_srcdir. PHP_ADD_BUILD_DIR may also be needed.

@TingDaoK
Copy link
Contributor

#90
I have a work in progress fix here. And seems like we finally have it working. We will fix the version issue asap! Thanks

Ask on pecl devel mailing list

I did, not get any response for over a month...

@remicollet
Copy link
Contributor Author

Ask on pecl devel mailing list

I did, not get any response for over a month...

Perhaps @cmb69 may help for that

@TingDaoK
Copy link
Contributor

Things were a bit off. But, we just released a new stable version 1.2.0, and it should be stable afterward. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

2 participants