PECL release follow up #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
remicollet
reviewed
Mar 15, 2023
ext/crt.c
Outdated
| @@ -263,6 +263,8 @@ static PHP_GINIT_FUNCTION(awscrt) { | |||
| awscrt_globals->log_level = 0; | |||
| } | |||
|
|
|||
| #define CRT_VERSION "0.1.0" | |||
There was a problem hiding this comment.
This is obviously not the proper version ?
There was a problem hiding this comment.
yeah, it's not. I was hoping to automate the release process and update this to real version here
graebm
approved these changes
Mar 15, 2023
remicollet
reviewed
Mar 16, 2023
| @@ -263,6 +263,8 @@ static PHP_GINIT_FUNCTION(awscrt) { | |||
| awscrt_globals->log_level = 0; | |||
| } | |||
|
|
|||
| #define CRT_VERSION "1.0.4" | |||
|
|
|||
There was a problem hiding this comment.
I recommend you use the normalized PHP_AWSCRT_VERSION macro name, and define it in some header in package root directory, so this version will be checked by pecl during upload
See https://github.com/php/web-pecl/blob/master/public_html/release-upload.php#L140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PECL release issue again:
Published to PECL with the help from @sdavtaker and found out issues...
awscrt.stub.phpwas ignored by PECLMy assumption, as I cannot find anything about how PECL really build your package:
awscrt.stub.phpassrcinstead ofscriptChecked the version we published before and found the Makefile we had changed a lot with the
srcdirandbuilddirfrom phpize and configure. So, adapt that change here.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.