Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Undefined function 'AWS\CRT\HTTP\InvalidArgumentException' #102

Merged
merged 3 commits into from
Jul 20, 2023
Merged

fix: Undefined function 'AWS\CRT\HTTP\InvalidArgumentException' #102

merged 3 commits into from
Jul 20, 2023

Conversation

yslinear
Copy link
Contributor

@yslinear yslinear commented Jul 17, 2023 •
edited
Loading

*Issue #, if available:

*Description of changes:

Changed throw InvalidArgumentException to throw new \InvalidArgumentException

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

waahm7
waahm7 approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@waahm7 waahm7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating the PR. LGTM if the CI passes.

@waahm7 waahm7 merged commit 2f1dc7b into awslabs:main Jul 20, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waahm7 waahm7 waahm7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yslinear @waahm7