fix win build #72
Merged
fix win build #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waahm7
approved these changes
Nov 3, 2022
DmitriyMusatkin
approved these changes
Nov 3, 2022
graebm
requested changes
Nov 3, 2022
graebm
approved these changes
Nov 22, 2022
Comment on lines
+54
to
+60
| Note: for VS2017, Cmake will default to build for Win32, refer to [here](https://cmake.org/cmake/help/latest/generator/Visual%20Studio%2015%202017.html). If you are building for x64 php, you can set environment variable as follow to let cmake pick x64 compiler. | ||
|
|
||
| ```bat | ||
| set CMAKE_GENERATOR=Visual Studio 15 2017 | ||
| set CMAKE_GENERATOR_PLATFORM=x64 | ||
| ``` | ||
|
|
There was a problem hiding this comment.
I never needed to do this on my machine
I believe using the recommended scripts like phpsdk-vs16-x64.bat from php-sdk-binary-tools sets this up to work correctly...
Maybe just revert changes to the README we'll fix it up later once we get a better grip on all this?
There was a problem hiding this comment.
from the customer issue here and what I tested with the instruction from our README.
""" From VS2017 Command Prompt
> C:\php-sdk\phpsdk-vc15-x64.bat
I met the issue that Cmake picked up x86 as generator platform. You can check the log from the customer issue. The phpsdk-vc15-x64.bat doesn't set the target platform correctly I believe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.