Rewrite script #87
Merged
Rewrite script #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graebm
reviewed
Feb 27, 2023
dev-scripts/prepare_pecl_release.py
Outdated
Comment on lines
48
to
50
| except subprocess.CalledProcessError as e: | ||
| print(f'ERROR PROCESSING review package.xml: {e}') | ||
| exit(1) |
There was a problem hiding this comment.
I'd rather we NOT try and catch the exception, so it's clear which line caused the error.
the cause/effect will be more clear if we print out the cmd being run (see above suggestion about run() helper)
or put the try/catch in the run() helper, and you can just sys.exit('FAILED') because who needs a stack trace, it's obvious which command failed, it's the one being run
There was a problem hiding this comment.
sure, just put a try/catch for prepare_pecl_package_xml.py for now to remind people check package.xml for error details.
Merged
TingDaoK
force-pushed
the
rewrite-script
branch
from
51c7239
to
d143ec4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.