[Replicate] compatibility with PHP 5.x #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waahm7
approved these changes
Mar 24, 2023
Comment on lines
+40
to
+41
| USE_OPENSSL=OFF make | ||
| ./dev-scripts/run_tests.sh |
There was a problem hiding this comment.
Debatable: maybe we should update our CI to run it with the same version of OpenSSL instead of AWS-LC.
There was a problem hiding this comment.
we tried, but it was going to take a lot more work, and this seemed like a reasonable workaround for now
graebm
approved these changes
Mar 24, 2023
Comment on lines
+40
to
+41
| USE_OPENSSL=OFF make | ||
| ./dev-scripts/run_tests.sh |
There was a problem hiding this comment.
add comments explaining hack
Suggested change
| USE_OPENSSL=OFF make | |
| ./dev-scripts/run_tests.sh | |
| # Normally, CRT uses the system's default libcrypto.so. | |
| # But in this CI run, PHP 5.5 is using a different older libcrypto.so. | |
| # When an applications uses two different libcrypto.so at the same time, things tend to explode. | |
| # Therefore, in this CI run we build AWS-LC statically, and use its libcrypto.a instead. | |
| USE_OPENSSL=OFF make | |
| ./dev-scripts/run_tests.sh |
There was a problem hiding this comment.
added a bit more to explain that php5.5 cannot build with openssl>=1.1 referring to shivammathur/setup-php#714 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#95
original: #96
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.