MQTT311 extra connection callbacks #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… extra_connection_callbacks
…ike we expect in ALL places
TwistedTwigleg
commented
Feb 9, 2023
|
Note: Once merged, a follow-up PR will need to be made in the Python V2 SDK to expose the new callbacks, as the MQTT311 builder in the V2 SDK currently doesn't directly pass the |
… extra_connection_callbacks
xiazhvera
approved these changes
Jun 9, 2023
|
Thanks! Merging into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds additional connection callbacks to MQTT311. Specifically, adds
onConnectionSuccess,onConnectionFailure, andonConnectionClosedThese callbacks mirror those in V1.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.