MuslLinux Wheels #480
Merged
MuslLinux Wheels #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graebm
approved these changes
Jun 13, 2023
|
|
||
| /opt/python/cp311-cp311/bin/python setup.py sdist bdist_wheel | ||
| auditwheel repair --plat musllinux_1_1_x86_64 dist/awscrt-*cp311*.whl | ||
|
|
There was a problem hiding this comment.
trivial: Can you add the following comment to all these copy/pasty files? Just to help out any future maintainers
Suggested change
| # Don't need to build wheels for Python 3.12 and later. | |
| # The 3.11 wheel uses the stable ABI, so it works with newer versions too. | |
I guess it's weird, since we haven't merge #479 yet ... maybe add the comment to the existing files in that PR, and to the new files in this PR? or just add it to all of them here 🤷♀️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.