Update crash handler behavior to opt-in #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waahm7
changed the title
graebm
reviewed
Jun 29, 2023
graebm
approved these changes
Jun 29, 2023
source/module.c
Outdated
| @@ -804,6 +804,7 @@ static PyMethodDef s_module_methods[] = { | |||
|
|
|||
| static const char s_module_name[] = "_awscrt"; | |||
| PyDoc_STRVAR(s_module_doc, "C extension for binding AWS implementations of MQTT, HTTP, and friends"); | |||
| AWS_STATIC_STRING_FROM_LITERAL(s_crash_handler_env_var, "AWS_CRT_ENABLE_CRASH_HANDLER"); | |||
There was a problem hiding this comment.
debatable: shorter name, similar to pre-existing "AWS_CRT_MEMORY_TRACING"?
Suggested change
| AWS_STATIC_STRING_FROM_LITERAL(s_crash_handler_env_var, "AWS_CRT_ENABLE_CRASH_HANDLER"); | |
| AWS_STATIC_STRING_FROM_LITERAL(s_crash_handler_env_var, "AWS_CRT_CRASH_HANDLER"); |
|
|
||
| /* Don't report this memory when dumping possible leaks. */ | ||
| struct aws_allocator *nontracing_allocator = aws_default_allocator(); | ||
|
|
||
| struct aws_string *crash_handler_env = NULL; |
There was a problem hiding this comment.
Speaking of "AWS_CRT_MEMORY_TRACING", we have a hack so that it's always turned on when tests run. let's do the same thing and always turn on the crash handler
Co-authored-by: Michael Graeb <graebm@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Our current crash handler unintentionally catches crashes from other Python libraries that utilize native code. The stacktrace dumped by the crash handler makes it look like our fault as it contains
PyInt_initcalls at the top of the stack trace. These calls, in reality, are simply function calls made to print the stack trace and printed asPyInt_initin release mode. To address this, this PR alters the crash handler to be an opt-in feature, disabling its automatic registration. Users can enable the crash handler by setting an env variable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.