glue factory duplication

awslabs · Apr 5, 2023 · 0dd8e91 · 0dd8e91
1 parent d76a892
commit 0dd8e91
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/src/core/glue-factory.ts b/src/core/glue-factory.ts
@@ -5,15 +5,18 @@ import { overrideProps } from "./utils";
 
 export class GlueFactory {
   public static job(scope: Construct, id: string, props: glue.JobProps) {
+    const securityConfiguration = !props.securityConfiguration
+      ? new glue.SecurityConfiguration(scope, `${id}-security-configuration`, {
+          s3Encryption: {
+            mode: glue.S3EncryptionMode.S3_MANAGED,
+          },
+        })
+      : undefined;
     const defaultProps: Partial<glue.JobProps> = {
       maxConcurrentRuns: 1,
       maxRetries: 1,
       timeout: cdk.Duration.hours(10),
-      securityConfiguration: new glue.SecurityConfiguration(scope, `${id}-security-configuration`, {
-        s3Encryption: {
-          mode: glue.S3EncryptionMode.S3_MANAGED,
-        },
-      }),
+      securityConfiguration: securityConfiguration,
     };
 
     const mergedProps = overrideProps(defaultProps, props);

diff --git a/src/stages/glue-transform.ts b/src/stages/glue-transform.ts
@@ -110,6 +110,7 @@ export class GlueTransformStage extends StateMachineStage {
       role: role,
       databaseName: props.databaseName,
       targets: targets,
+      ...props.crawlerProps,
     });
     return crawler;
   }