Skip to content

Commit

Permalink
feat: Support local package path install in CICD synth action pre-pub…
Browse files Browse the repository at this point in the history
…lic release (#160)

* adding temp npm install of ddk core package

* parameterizing local package path

* adding param to pipeilne

* adding api
  • Loading branch information
malachi-constant committed Aug 31, 2022
1 parent b3743f3 commit 0e01da8
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 3 deletions.
22 changes: 22 additions & 0 deletions API.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions src/cicd/actions.ts
Expand Up @@ -20,6 +20,7 @@ export interface GetSynthActionProps {
readonly codeartifactRepository?: string;
readonly codeartifactDomain?: string;
readonly codeartifactDomainOwner?: string;
readonly localPackagePath?: string;
}

export interface CodeCommitSourceActionProps {
Expand All @@ -38,7 +39,7 @@ export function getCodeCommitSourceAction(scope: Construct, props: CodeCommitSou

export function getSynthAction(props: GetSynthActionProps): CodeBuildStep {
var installCommands;
installCommands = [`npm install -g aws-cdk@${props.cdkVersion ? props.cdkVersion : ''}`];
installCommands = [`npm install -g aws-cdk@${props.cdkVersion ? props.cdkVersion : 'latest'}`];

// if (all([codeArtifactRepository, codeArtifactDomain, codeArtifactDomainOwner])) {
// if (!rolePolicyStatements) {
Expand All @@ -47,8 +48,8 @@ export function getSynthAction(props: GetSynthActionProps): CodeBuildStep {

// install_commands.psuh(`aws codeartifact login --tool pip --repository ${codeArtifactRepository} --domain ${codeArtifactDomain} --domain-owner ${codeArtifactDomainOwner}`);
// }

installCommands.push('pip install -r requirements.txt');
const localPackagePath = props.localPackagePath ?? 'package/';
installCommands.push(`npm install ${localPackagePath} || true`); // will need to be replaced with `npm install aws-ddk-core@${version}` when available
return new CodeBuildStep('Synth', {
input: props.codePipelineSource,
installCommands: installCommands,
Expand Down
2 changes: 2 additions & 0 deletions src/cicd/pipelines.ts
Expand Up @@ -27,6 +27,7 @@ export interface SynthActionProps {
readonly codeartifactDomainOwner?: string;
readonly rolePolicyStatements?: PolicyStatement[];
readonly synthAction?: CodeBuildStep;
readonly localPackagePath?: string;
}

export interface AddApplicationStageProps {
Expand Down Expand Up @@ -118,6 +119,7 @@ export class CICDPipelineStack extends Stack {
codeartifactRepository: props.codeartifactRepository, // || this._artifactory_config.get('repository'),
codeartifactDomain: props.codeartifactDomain, // || this._artifactory_config.get('domain'),
codeartifactDomainOwner: props.codeartifactDomainOwner, //|| this._artifactory_config.get('domain_owner')
localPackagePath: props.localPackagePath,
});
return this;
}
Expand Down

0 comments on commit 0e01da8

Please sign in to comment.