fix: Remove whitespace from glue job sec configuration Id (#275)

* security configuration can't handle whitespace in id * removing explicit sec conf name
awslabs · Mar 7, 2023 · 3fa0ecd · 3fa0ecd
1 parent a4731ef
commit 3fa0ecd
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 13 deletions.
diff --git a/integ/integ.glue-transform.test.ts b/integ/integ.glue-transform.test.ts
@@ -18,28 +18,31 @@ interface GlueTransformStageTestStackProps extends StateMachineStageProps {
 }
 
 class GlueTransformStageTestStack extends cdk.Stack {
+  readonly job: glue_alpha.IJob;
   constructor(scope: Construct, id: string, props: GlueTransformStageTestStackProps) {
     super(scope, id, props);
 
-    new GlueTransformStage(this, "Stage", {
+    const stage = new GlueTransformStage(this, "Stage", {
       ...props,
     });
+    this.job = stage.glueJob
   }
 }
 
 const app = new cdk.App();
-new integration.IntegTest(app, "Glue Tranform Stage Integration Tests", {
+const stack = new GlueTransformStageTestStack(app, "GlueTransformBasic", {
+  jobProps: {
+    executable: glue_alpha.JobExecutable.pythonShell({
+      glueVersion: glue_alpha.GlueVersion.V1_0,
+      pythonVersion: glue_alpha.PythonVersion.THREE,
+      script: glue_alpha.Code.fromAsset(path.join(__dirname, "/src/glue_script.py")),
+    })
+  },
+  crawlerName: "dummy-crawler",
+});
+const integTest = new integration.IntegTest(app, "Glue Transform Stage Integration Tests", {
     testCases: [
-      new GlueTransformStageTestStack(app, "GlueTransformBasic", {
-        jobProps: {
-          executable: glue_alpha.JobExecutable.pythonShell({
-            glueVersion: glue_alpha.GlueVersion.V1_0,
-            pythonVersion: glue_alpha.PythonVersion.THREE,
-            script: glue_alpha.Code.fromAsset(path.join(__dirname, "/src/glue_script.py")),
-          })
-        },
-        crawlerName: "dummy-crawler",
-      }),
+      stack
     ],
     diffAssets: true,
     stackUpdateWorkflow: true,
@@ -57,3 +60,7 @@ new integration.IntegTest(app, "Glue Tranform Stage Integration Tests", {
       },
     },
 });
+
+integTest.assertions.awsApiCall("Glue", "startJobRun", {
+  JobName: stack.job.jobName,
+});
diff --git a/src/core/glue-defaults.ts b/src/core/glue-defaults.ts
@@ -10,7 +10,6 @@ export class GlueDefaults {
       maxRetries: 1,
       timeout: cdk.Duration.hours(10),
       securityConfiguration: new glue.SecurityConfiguration(scope, id, {
-        securityConfigurationName: `${id}-security-config`,
         s3Encryption: {
           mode: glue.S3EncryptionMode.S3_MANAGED,
         },