Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(core): Refactor Stage construct to include Event, StateMachine and DataStage #104

Merged
merged 2 commits into from
Apr 26, 2022
Merged

(core): Refactor Stage construct to include Event, StateMachine and DataStage #104

merged 2 commits into from
Apr 26, 2022

Conversation

jaidisido
Copy link
Contributor

Feature or Bugfix

  • Refactoring

Detail

  • Add a Stage base class
  • Refactor DataStage class
  • Add EventStage and StateMachine classes
  • Refactor S3Event, AppFlow, Athena and Glue stages

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jaidisido jaidisido self-assigned this Apr 22, 2022
@jaidisido jaidisido added this to the 0.4.0 milestone Apr 22, 2022
@jaidisido jaidisido added this to In Progress in Roadmap Apr 22, 2022
@jaidisido jaidisido moved this from In Progress to Review in Roadmap Apr 25, 2022
malachi-constant
malachi-constant approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@malachi-constant malachi-constant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Abstracting out all the SFN configuration from these stages I think is a big win and Stage vs EventStage works for me. Great work, thanks.

@jaidisido jaidisido merged commit 893083b into main Apr 26, 2022
@jaidisido jaidisido deleted the refactor/core-stages branch April 26, 2022 09:37
@jaidisido jaidisido moved this from Review to Done in Roadmap Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Misdre Misdre Misdre approved these changes

@malachi-constant malachi-constant malachi-constant approved these changes

@cnfait cnfait cnfait approved these changes

@kukushking kukushking Awaiting requested review from kukushking

Assignees

@jaidisido jaidisido

Labels
core effort/medium enhancement New feature or request p0
Projects
Roadmap
Done
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jaidisido @Misdre @malachi-constant @cnfait