Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(cli): Add --all to ddk deploy #111

Merged
merged 1 commit into from
May 25, 2022
Merged

(cli): Add --all to ddk deploy #111

merged 1 commit into from
May 25, 2022

Conversation

jaidisido
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Detail

  • Add missing --all flag to ddk deploy

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jaidisido jaidisido self-assigned this May 20, 2022
@jaidisido jaidisido added bug Something isn't working cli effort/small p0 labels May 20, 2022
malachi-constant
malachi-constant approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@malachi-constant malachi-constant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I assume we wouldn't be handling selective deployment of multiple ddk stacks within a namespace at this time.

@kukushking kukushking merged commit c77b757 into main May 25, 2022
@jaidisido jaidisido deleted the issue-110-cli-deploy branch May 26, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malachi-constant malachi-constant malachi-constant approved these changes

@cnfait cnfait Awaiting requested review from cnfait

@kukushking kukushking Awaiting requested review from kukushking

Assignees

@jaidisido jaidisido

Labels
bug Something isn't working cli effort/small p0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jaidisido @malachi-constant @kukushking