Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(cli) add 'stacks' argument for 'ddk deploy' #129

Merged

Conversation

malachi-constant
Copy link
Contributor

Enhancement

  • Add argument for ddk deploy to allow explicitly setting stacks to deploy

Usage

  • ddk deploy StackA StackB

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant malachi-constant self-assigned this Jul 1, 2022
@malachi-constant malachi-constant linked an issue Jul 1, 2022 that may be closed by this pull request
@malachi-constant malachi-constant added this to the 0.6.0 milestone Jul 1, 2022
@malachi-constant
Copy link
Contributor Author

I think we need to put in some type of testing for deploy outside of just --help. Will we need some sort of dummy DDK stack to use in order to mock a deploy ?

cli/aws_ddk/__main__.py Outdated Show resolved Hide resolved
@malachi-constant malachi-constant merged commit e6829b6 into main Jul 7, 2022
@kukushking
Copy link
Contributor

kukushking commented Jul 7, 2022

@malachi-constant looks good thanks - feel free to merge! To your question - yeah I think for a proper E2E test we would have to provide a complete dummy app (with ddk.json & app.py)... how about we just find a way to assert the cdk command is as expected, and assume cdk itself works?

@jaidisido jaidisido deleted the 121-cli-add-stack-name-parameter-to-ddk-deploy branch August 1, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(cli) add stack name parameter to ddk deploy
2 participants