Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Created DataStage, DataPipeline and SQSToLambda constructs #138

Merged
merged 1 commit into from
Aug 16, 2022
Merged

feat: Created DataStage, DataPipeline and SQSToLambda constructs #138

merged 1 commit into from
Aug 16, 2022

Conversation

LeonLuttenberger
Copy link
Contributor

Feature

  • Created Stage, DataStage and DataPipeline constructs in TypeScript CDK
  • Created SQSToLambda stage in TypeScript CDK
  • Added unit tests for the data pipeline and the SQSToLambda stage

Relates

#135

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@LeonLuttenberger LeonLuttenberger added this to the 1.0.0 milestone Aug 10, 2022
@LeonLuttenberger LeonLuttenberger self-assigned this Aug 10, 2022
@LeonLuttenberger LeonLuttenberger linked an issue Aug 10, 2022 that may be closed by this pull request
Typescript: DataStage & DataPipeline Construct Conversion #135
Closed
kukushking
kukushking approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@kukushking kukushking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as agreed this is a 1:1 translation of existing Python code. Very excited to being able to try it out in other languages!

jaidisido
jaidisido approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@jaidisido jaidisido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you

@LeonLuttenberger LeonLuttenberger merged commit 5523987 into typescript-conversion Aug 16, 2022
@LeonLuttenberger LeonLuttenberger deleted the 135-typescript-datastage-datapipeline-construct-conversion branch August 16, 2022 13:50
@malachi-constant malachi-constant added this to In Review in Roadmap Jan 3, 2023
@malachi-constant malachi-constant moved this from In Review to Done in Roadmap Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kukushking kukushking kukushking approved these changes

@jaidisido jaidisido jaidisido approved these changes

@malachi-constant malachi-constant Awaiting requested review from malachi-constant

@cnfait cnfait Awaiting requested review from cnfait

Assignees

@LeonLuttenberger LeonLuttenberger

Labels
typescript
Projects
Roadmap
Done
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Typescript: DataStage & DataPipeline Construct Conversion
3 participants
@LeonLuttenberger @kukushking @jaidisido