feat: Implement BaseStack in Typescript #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonLuttenberger
requested review from
kukushking,
malachi-constant,
jaidisido and
cnfait
malachi-constant
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
LGTM
I've added #147 so we remember to replace Stack where appropriate across the codebase.
LeonLuttenberger
added a commit
that referenced
this pull request
Aug 19, 2022
This reverts commit 2642d71.
LeonLuttenberger
added a commit
that referenced
this pull request
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
Implementing
BaseStackin Typescript CDK. The new stack does not include theenvironmentIdyet, as it related to the config portion, which we haven't implemented yet.Relates
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.