Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CICD: Presynth install commands -> optional #162

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

malachi-constant
Copy link
Contributor

Feature or Bugfix

  • Making install commands in the synth action stage optional as these may change in different languages and not be necessary all of the time.

Detail

  • Python implementation requires [] in most cases while Typescript requires [npm install]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant malachi-constant self-assigned this Sep 1, 2022
@malachi-constant malachi-constant changed the base branch from main to typescript-conversion September 1, 2022 16:32
@malachi-constant malachi-constant changed the title CICD: Presynth install commands -> optional bug: CICD: Presynth install commands -> optional Sep 1, 2022
@malachi-constant malachi-constant changed the title bug: CICD: Presynth install commands -> optional fix: CICD: Presynth install commands -> optional Sep 1, 2022
@malachi-constant malachi-constant merged commit 1f4634e into typescript-conversion Sep 1, 2022
@malachi-constant malachi-constant deleted the presynth-install-commands branch September 1, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants