Bug: Windows ddk deploy Issue
#180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malachi-constant
changed the title
ddk deploy Issueddk deploy Issue
malachi-constant
changed the title
ddk deploy Issueddk deploy Issue
LeonLuttenberger
approved these changes
Oct 31, 2022
jaidisido
approved these changes
Nov 1, 2022
malachi-constant
deleted the
178-bug-ddk-deploy-fails-on-windows-11-pro
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates
Details
cdkwithin asubprocess.Popen, but is able to findcdk.CMD.text=Falseinsubprocess.Popenfor this use case and errors with this error. By setting stdout to text not bytes we seem to be able to avoid this issue in the case of a Windows OS.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.