-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Allowing alarms to be disabled in stages #205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an idea, but I wonder if it would be better to just have a standard alarms_enabled
parameter that's define in Stage
, and is therefore inherited by all the stages.
I'm just thinking it might be easier if all the stages have the same parameter which can be used to disable the alarm, as opposed to each stage having it be a different name.
Yep that's kind of what I was thinking with the |
Enhancement
DataStages
by settingalarm_threshold
value to0
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.