Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ddk configurator #254

Merged
merged 18 commits into from
Feb 24, 2023
Merged

feat: ddk configurator #254

merged 18 commits into from
Feb 24, 2023

Conversation

malachi-constant
Copy link
Contributor

@malachi-constant malachi-constant commented Feb 10, 2023 •
edited

@malachi-constant malachi-constant self-assigned this Feb 10, 2023
@malachi-constant malachi-constant changed the title 248 ddk config common patterns feat: ddk config tagging Feb 10, 2023
@malachi-constant malachi-constant added this to the 1.0.0 milestone Feb 10, 2023
@malachi-constant malachi-constant added this to In Review in Roadmap Feb 10, 2023
@malachi-constant malachi-constant changed the title feat: ddk config tagging feat: ddk configurator Feb 10, 2023
@malachi-constant malachi-constant mentioned this pull request Feb 10, 2023
Closed
3 tasks
@malachi-constant malachi-constant changed the base branch from 246-ddk-config to typescript-conversion February 10, 2023 22:35
@malachi-constant malachi-constant moved this from In Review to In Progress in Roadmap Feb 10, 2023
@malachi-constant malachi-constant moved this from In Progress to In Review in Roadmap Feb 16, 2023
jaidisido
jaidisido reviewed Feb 20, 2023
View reviewed changes
Copy link
Contributor

@jaidisido jaidisido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - need clarification on a couple of points

test/base-stack.test.ts Show resolved Hide resolved
test/test-config.json Show resolved Hide resolved
This was linked to issues Feb 23, 2023
typescript: ddk config to support environment based resource configuration #246
Closed
typescript: ddk config support global security settings to replace BaseStack funtionality #247
Closed
typescript: ddk config tagging patterns #248
Closed
config: figure out if and how to implement IaC controls that can't be handled by property overrides #257
Closed
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
  • Commit ID: cbf99db
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

LeonLuttenberger
LeonLuttenberger reviewed Feb 23, 2023
View reviewed changes
Copy link
Contributor

@LeonLuttenberger LeonLuttenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overrall! I left a couple of minor comments

src/cicd/pipelines.ts Outdated Show resolved Hide resolved
src/config/configurator.ts Show resolved Hide resolved
src/cicd/pipelines.ts Outdated Show resolved Hide resolved
src/cicd/pipelines.ts Outdated Show resolved Hide resolved
src/cicd/pipelines.ts Outdated Show resolved Hide resolved
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
  • Commit ID: 626aa18
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant malachi-constant moved this from In Review to Backlog in Roadmap Feb 24, 2023
@malachi-constant malachi-constant moved this from Backlog to Done in Roadmap Feb 24, 2023
@malachi-constant malachi-constant merged commit 9b7f48d into typescript-conversion Feb 24, 2023
@malachi-constant malachi-constant deleted the 248-ddk-config-common-patterns branch March 30, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonLuttenberger LeonLuttenberger LeonLuttenberger approved these changes

@cnfait cnfait Awaiting requested review from cnfait

@kukushking kukushking Awaiting requested review from kukushking

@anmolsgandhi anmolsgandhi Awaiting requested review from anmolsgandhi

@jaidisido jaidisido Awaiting requested review from jaidisido

Assignees

@malachi-constant malachi-constant

Labels
core feature-request typescript
Projects
Roadmap
Done
Milestone
1.0.0
3 participants
@malachi-constant @LeonLuttenberger @jaidisido