Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: standardize defaults approach in ddk core #258

Merged
merged 11 commits into from
Feb 27, 2023
Merged

feat: standardize defaults approach in ddk core #258

merged 11 commits into from
Feb 27, 2023

Conversation

malachi-constant
Copy link
Contributor

@malachi-constant malachi-constant commented Feb 17, 2023 •
edited

Closes #225

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant malachi-constant added this to the 1.0.0 milestone Feb 17, 2023
@malachi-constant malachi-constant self-assigned this Feb 17, 2023
@malachi-constant malachi-constant added this to In Progress in Roadmap Feb 17, 2023
@malachi-constant malachi-constant marked this pull request as draft February 17, 2023 20:54
@malachi-constant malachi-constant linked an issue Feb 22, 2023 that may be closed by this pull request
typescript: Add default props for all resources #225
Closed
@malachi-constant malachi-constant removed this from In Progress in Roadmap Feb 22, 2023
@malachi-constant malachi-constant marked this pull request as ready for review February 23, 2023 15:57
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
  • Commit ID: 51880ec
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
  • Commit ID: 51880ec
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
  • Commit ID: 2b1c9c7
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
  • Commit ID: 5277081
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant malachi-constant merged commit c2fa8ea into typescript-conversion Feb 27, 2023
@malachi-constant malachi-constant deleted the ts/standardize-defaults branch February 27, 2023 23:48
@malachi-constant malachi-constant mentioned this pull request Feb 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonLuttenberger LeonLuttenberger LeonLuttenberger approved these changes

@jaidisido jaidisido Awaiting requested review from jaidisido

@anmolsgandhi anmolsgandhi Awaiting requested review from anmolsgandhi

@cnfait cnfait Awaiting requested review from cnfait

@kukushking kukushking Awaiting requested review from kukushking

Assignees

@malachi-constant malachi-constant

Labels
core feature-request
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

typescript: Add default props for all resources
2 participants
@malachi-constant @LeonLuttenberger